asp.net - C# is there a nicer way of writing this? -

- 

int uploadsid; int pagenumber; int x; int y; int w; int h;  bool isvaliduploadid = int.tryparse(context.request.querystring["uploadid"], out uploadsid); bool isvalidpage = int.tryparse(context.request.querystring["page"], out pagenumber); bool isvalidx = int.tryparse(context.request.querystring["x"], out x); bool isvalidy = int.tryparse(context.request.querystring["y"], out y); bool isvalidw = int.tryparse(context.request.querystring["w"], out w); bool isvalidh = int.tryparse(context.request.querystring["h"], out h);  if (isvaliduploadid && isvalidpage && isvalidx && isvalidy & isvalidw & isvalidh) {

this ajax handler, checking passed params ok. considered bad, , there better way write this, or not important?

assuming you're not going use individual bool variables elsewhere, could write as:

int uploadsid, pagenumber, x, y, w, h; if (int.tryparse(context.request.querystring["uploadid"], out uploadsid) &&     int.tryparse(context.request.querystring["page"], out pagenumber) &&     int.tryparse(context.request.querystring["x"], out x) &&     int.tryparse(context.request.querystring["y"], out y) &&     int.tryparse(context.request.querystring["w"], out w) &&     int.tryparse(context.request.querystring["h"], out h)) { }

you may want extract out int.tryparse(context.request.querystring[name], out variable separate method, leaving like:

int uploadsid, pagenumber, x, y, w, h; if (tryparsecontextint32("uploadid", out uploadsid) &&     tryparsecontextint32("page", out pagenumber) &&     tryparsecontextint32("x", out x) &&     tryparsecontextint32("y", out y) &&     tryparsecontextint32("w", out w) &&     tryparsecontextint32("h", out h)) { }

alternatively, encapsulate context data new type tryparse method, you'd have like:

pagedetails details; if (pagedetails.tryparse(context.request.querystring)) {     // access details.page, details.uploadid etc }

that's more work, think make code cleaner.


Comments

Post a Comment

Popular posts from this blog

javascript - Enclosure Memory Copies -

-
function myclass() { //lots , lots of vars , code here. this.bar = function() { //do numerous enclosed myclass vars } this.foo = function() { alert('hello'); //don't enclosed variables. } } each instance of myclass gets own copy of bar , foo, why prototyped methods use less memory. however, know more memory use of inner methods. it seems obvious me (1) below must true. agree? not distinct myclass instances have own distinct copies of bar, must have own distinct copies of myclass enclosure. (or else how bar method keep myclass variables straight on per instance basis?) now (2) question i'm after. since inner foo method doesn't use in myclass enclosure natural qustion is: javascript smart enough not keep myclass enclosure in memory use of foo? this depend entirely on implementation not language. naive implementations keep far more around others. answer true e.g. v8 (chrome's js engine) may not true spider...
Read more

php - Replacing tags in braces, even nested tags, with regex -

-
example preg_replace('/\{[a-za-z.,\(\)0-9]+\}/', 'replaced', 'lorem ipsum dolor sit {tag1({tag2()})}, consectetur adipiscing elit.'); the result: lorem ipsum dolor sit {tag1(replaced)}, consectetur adipiscing elit. question as can see "tag2" has been replaced, want replace "tag1" know how can this? (in cases might this: {tag1({tag2({tag3()})})}) , on.) btw using preg_replace_callback, easier show preg_replace here site can test code: http://www.spaweditor.com/scripts/regex/index.php you need add curly braces character set. here's pattern used: /\{[a-za-z.,\(\)\{\}0-9]+\}/ and here result: "lorem ipsum dolor sit replaced, consectetur adipiscing elit."
Read more