javascript - Action on jQuery Plugin Is Always Last Option? -

-

my plugin i'm writing right click context menu internal app, , can't figure out why happening.

here testing code:

$('.item').rightclickmenu([ {   icon:'http://cdn1.iconfinder.com/data/icons/silk2/exclamation.png',   title:'alert',   action:function(){     alert('here example alert!');   } }, {   icon:'http://cdn1.iconfinder.com/data/icons/silk2/error.png',   title:'console.log',   action:function(){     console.log('here example console.log()!');   } } ]);

the relevant jquery plugin code is:

for(x in items){           $list.append('<li class="rightclickmenuoption'+x+'"><img src="'+items[x].icon+'">'+items[x].title+'</li>')             .find('.rightclickmenuoption'+x)               .bind('click',function(){                 items[x].action();               });         }

demo: http://jsbin.com/uxali4/3/

this fix it: http://jsbin.com/uxali4/4/edit

you're creating closure. of invoked methods in for..in loop copy same parent context internal [[scope]] property activation object. hence, methods access same variable x. need invoke function fix this.

for(x in items){       (function(index) {         $list.append('<li class="rightclickmenuoption'+index+'"><img src="'+items[index].icon+'">'+items[index].title+'</li>')           .find('.rightclickmenuoption'+index)             .bind('click',function(){               items[index].action();             });       }(x)); }

update

have @ http://jsperf.com/for-in-vs-for

that should demonstrate pretty impressivly speed difference between for , for..in


Comments

Post a Comment

Popular posts from this blog

javascript - Enclosure Memory Copies -

-
function myclass() { //lots , lots of vars , code here. this.bar = function() { //do numerous enclosed myclass vars } this.foo = function() { alert('hello'); //don't enclosed variables. } } each instance of myclass gets own copy of bar , foo, why prototyped methods use less memory. however, know more memory use of inner methods. it seems obvious me (1) below must true. agree? not distinct myclass instances have own distinct copies of bar, must have own distinct copies of myclass enclosure. (or else how bar method keep myclass variables straight on per instance basis?) now (2) question i'm after. since inner foo method doesn't use in myclass enclosure natural qustion is: javascript smart enough not keep myclass enclosure in memory use of foo? this depend entirely on implementation not language. naive implementations keep far more around others. answer true e.g. v8 (chrome's js engine) may not true spider...
Read more

php - Replacing tags in braces, even nested tags, with regex -

-
example preg_replace('/\{[a-za-z.,\(\)0-9]+\}/', 'replaced', 'lorem ipsum dolor sit {tag1({tag2()})}, consectetur adipiscing elit.'); the result: lorem ipsum dolor sit {tag1(replaced)}, consectetur adipiscing elit. question as can see "tag2" has been replaced, want replace "tag1" know how can this? (in cases might this: {tag1({tag2({tag3()})})}) , on.) btw using preg_replace_callback, easier show preg_replace here site can test code: http://www.spaweditor.com/scripts/regex/index.php you need add curly braces character set. here's pattern used: /\{[a-za-z.,\(\)\{\}0-9]+\}/ and here result: "lorem ipsum dolor sit replaced, consectetur adipiscing elit."
Read more